Graphpocalypse #9526
Graphpocalypse #9526
Conversation
- fix up a bunch of generic typing issues - deprecate some old / obsolete operations - finally implement addTreatedSubgraph()
|
Thanks for your pull request! This pull request does not follow the contribution rules. Could you have a look? ❌ The pull request title should contain at least 2 words to describe the change properly › This message was automatically generated. |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| } | ||
|
|
||
| private PersistentAttribute<? super J, ?> findAttributeInSupertypes(String attributeName) { | ||
| final PersistentAttribute<? super J, ?> attribute = managedType.findAttributeInSuperTypes( attributeName ); |
Check notice
Code scanning / CodeQL
Deprecated method or constructor invocation Note
hibernate-core/src/main/java/org/hibernate/graph/internal/RootGraphImpl.java
Fixed
Show fixed
Hide fixed
| if ( superType != null ) { | ||
| return superType.findAttributeInSuperTypes( name ); | ||
| else { | ||
| return supertype != null ? supertype.findAttributeInSuperTypes( name ) : null; |
Check notice
Code scanning / CodeQL
Deprecated method or constructor invocation Note
gavinking
force-pushed
the
graphpocalypse
branch
from
11caece to
61c94d9
Compare
- fix up typing issues with key/value subgraphs
gavinking
force-pushed
the
graphpocalypse
branch
from
61c94d9 to
eb45abe
Compare
|
|
||
| @Override | ||
| default <X> SubGraph<X> addSubgraph(String name) { | ||
| return addSubGraph( name ); |
Check notice
Code scanning / CodeQL
Deprecated method or constructor invocation Note
| @Override | ||
| <Y> SubGraph<Y> addTreatedSubgraph(Attribute<? super J, ? super Y> attribute, Class<Y> type); | ||
| default <X> SubGraph<X> addKeySubgraph(String name) { | ||
| return addKeySubGraph( name ); |
Check notice
Code scanning / CodeQL
Deprecated method or constructor invocation Note
- attempt to fill in unimplemented operations from JPA 3.2 - organize operations on Graph/GraphImplementor
gavinking
force-pushed
the
graphpocalypse
branch
from
f81b26a to
35fba77
Compare
| public <K> SubGraphImplementor<K> addMapKeySubgraph(MapAttribute<? super J, K, ?> attribute) { | ||
| throw new UnsupportedOperationException( "Not yet implemented" ); | ||
| public RootGraphImplementor<J> makeImmutableCopy(String name) { | ||
| return makeRootGraph( name, false ); |
Check notice
Code scanning / CodeQL
Deprecated method or constructor invocation Note
- important simplification
gavinking
force-pushed
the
graphpocalypse
branch
from
eede2b7 to
dfd4205
Compare
|
|
||
| @Override | ||
| default <X> SubGraph<X> addSubgraph(String name, Class<X> type) { | ||
| return addSubGraph( name ).addTreatedSubGraph( type ); |
Check notice
Code scanning / CodeQL
Deprecated method or constructor invocation Note
|
|
||
| @Override | ||
| default <X> SubGraph<X> addKeySubgraph(String name, Class<X> type) { | ||
| return addKeySubGraph( name ).addTreatedSubGraph( type ); |
Check notice
Code scanning / CodeQL
Deprecated method or constructor invocation Note
gavinking
force-pushed
the
graphpocalypse
branch
2 times, most recently
from
89e51eb to
f543986
Compare
- sort out handling of mutability - try to minimize diff
gavinking
force-pushed
the
graphpocalypse
branch
from
f543986 to
128221c
Compare
- improve error nessages and add toStrings()
gavinking
force-pushed
the
graphpocalypse
branch
from
0ddcbd8 to
e168efa
Compare
1 participant
[Please describe here what your change is about]
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license
and can be relicensed under the terms of the LGPL v2.1 license in the future at the maintainers' discretion.
For more information on licensing, please check here.